Fixes raddb - #11
Merged
Merged
Fixes raddb#11
Conversation
- Updated "polygone" to "polygon" in multiple files to correct spelling errors. - Adjusted docstrings and comments to improve clarity and maintain consistency in language (consistency with American English). - Corrected execution counts in tutorial notebooks to ensure proper order of execution.
…base (not used in this package)
RadDB stored four MeteoSwiss fields by name — HC_MCH, HC_PYART, HZT and a TEMP it derived itself — through a hardcoded POLAR_COLUMNS allowlist, and shipped raddb/hc_mapping.py to encode their classes. None of that belongs in a network-agnostic archive; it now lives in MCH_tools, which imports raddb. The allowlist was the real problem. It archived 5 of an FMI volume's 19 per-gate moments: HCLASS, VRADH, WRADH, TH, TV, SQIH, SNR, PMI, CSP, LOG, DBZHC, ZDRC, VRADDH and DBZV were all dropped without a word. A moment is now any data variable carried on both azimuth and range, so a network's own fields survive whatever they are called, and the per-ray/scalar metadata beside them (sweep_mode, prt_mode, nyquist_velocity — three of them strings) is excluded by dimension rather than by name. archive(variables=[...]) narrows it for a lean archive. Measured on the reference volumes: FMI 19, MCH 24, NEXRAD 6. Float columns are narrowed to float32 by dtype instead of a name set, so an unknown moment is stored as compactly as DBZH, and gate_id stays int64. _PLOT_DEFAULTS becomes public PLOT_DEFAULTS: the discrete-classification machinery is generic — FMI's HCLASS needs it as much as HC_MCH did — so it stays here while the class tables move out and are registered by whoever produces the data. Also drops discovery._parse_volume_time and _group_files_by_volume, dead duplicates of functions MCH_tools already has and uses. Archives written before this still read: the read path never had an allowlist. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…FMI radar usage - Revised the description of the demo pipeline to specify the use of two FMI radars. - Added detailed information about the data used in the notebooks, including specific dates and radar identifiers. - Clarified the importance of selecting appropriate times for data collection based on FMI's scanning schedule. - Updated instructions for running the notebooks with personal data, emphasizing the configuration cell. - Removed NEXRAD in tutorials due to different scan stategy
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 89.69% 89.38% -0.32%
==========================================
Files 25 23 -2
Lines 6678 6582 -96
==========================================
- Hits 5990 5883 -107
- Misses 688 699 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- update test script, fixed pre-commit error
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prework
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and communicate accordingly:
The PR fulfills these requirements:
bugfix-<some_key>-<word>doc-<some_key>-<word>tutorial-<some_key>-<word>feature-<some_key>-<word>refactor-<some_key>-<word>optimize-<some_key>-<word>fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Related GitHub issues and pull requests
Summary
Please explain the purpose and scope of your contribution.