Skip to content

fix(www): use siteConfig.url in sitemap and restore static generation - #1015

Merged
Yeom-JinHo merged 2 commits into
magicuidesign:mainfrom
zigzagdev:fix/www-sitemap-showcase-pages
Oct 5, 2026
Merged

Yeom-JinHo merged 2 commits into
magicuidesign:mainfrom
zigzagdev:fix/www-sitemap-showcase-pages

Conversation

@zigzagdev

Copy link
Copy Markdown
Contributor

Description

Showcase pages were never listed in sitemap.ts, leaving them out of search indexing entirely. Also switches domain resolution from the request Host header to siteConfig.url for consistency with the rest of the app, which lets the route go back to static generation.

Changes

  • Add showcase pages (showcaseSource) to the generated sitemap
  • Replace headers()-based host resolution with siteConfig.url, matching every other page in the app (robots.ts, absoluteUrl, etc.)
  • Re-enable static generation (revalidate = false, dynamic = "force-static") for app/sitemap.ts, since it no longer depends on a dynamic API

Motivation

/showcase/[...slug] pages are real, crawlable pages with their own generateStaticParams, but were silently excluded from the sitemap — hurting their discoverability in search. The route also trusted the request Host header to build canonical URLs, which is inconsistent with the rest of the app and forced the route off static generation on every request.

Breaking Changes

None.

Screenshots

Not applicable — no UI change.

Checklist

  • pnpm check passes locally — not run in this environment (dependencies not installed); please verify in CI
  • pnpm build passes locally — not run in this environment (dependencies not installed); please verify in CI
  • pnpm build:registry was run and the generated files are committed — not applicable, no registry/ or config/site.ts changes
  • PR title follows Conventional Commits

Showcase pages were never listed in sitemap.ts, leaving them out of
search indexing entirely. Also switch domain resolution from the
request Host header to siteConfig.url for consistency with the rest
of the app, which lets the route go back to static generation.
@vercel

vercel Bot commented Oct 2, 2026

Copy link
Copy Markdown

@zigzagdev is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo
Yeom-JinHo self-requested a review October 5, 2026 08:13
@Yeom-JinHo Yeom-JinHo changed the title fix(www): add showcase pages to sitemap, use siteConfig.url fix(www): use siteConfig.url in sitemap and restore static generation Oct 5, 2026

@Yeom-JinHo Yeom-JinHo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zigzagdev Thanks for the PR! I pushed a small follow-up to your branch that drops the showcase entries from the sitemap.
Those detail pages are pretty thin (just a title and a card), so I'd rather not submit them for indexing. The siteConfig.url and static generation changes are great, keeping those as-is.

@Yeom-JinHo
Yeom-JinHo merged commit cdb348c into magicuidesign:main Oct 5, 2026
6 of 7 checks passed
@zigzagdev
zigzagdev deleted the fix/www-sitemap-showcase-pages branch October 5, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants