Repository navigation
fix(www): use siteConfig.url in sitemap and restore static generation - #1015
Merged
Yeom-JinHo merged 2 commits intoOct 5, 2026
Merged
Conversation
Showcase pages were never listed in sitemap.ts, leaving them out of search indexing entirely. Also switch domain resolution from the request Host header to siteConfig.url for consistency with the rest of the app, which lets the route go back to static generation.
|
@zigzagdev is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
Yeom-JinHo
self-requested a review
October 5, 2026 08:13
Yeom-JinHo
approved these changes
Oct 5, 2026
Yeom-JinHo
left a comment
Member
There was a problem hiding this comment.
@zigzagdev Thanks for the PR! I pushed a small follow-up to your branch that drops the showcase entries from the sitemap.
Those detail pages are pretty thin (just a title and a card), so I'd rather not submit them for indexing. The siteConfig.url and static generation changes are great, keeping those as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Showcase pages were never listed in
sitemap.ts, leaving them out of search indexing entirely. Also switches domain resolution from the requestHostheader tositeConfig.urlfor consistency with the rest of the app, which lets the route go back to static generation.Changes
showcaseSource) to the generated sitemapheaders()-based host resolution withsiteConfig.url, matching every other page in the app (robots.ts,absoluteUrl, etc.)revalidate = false,dynamic = "force-static") forapp/sitemap.ts, since it no longer depends on a dynamic APIMotivation
/showcase/[...slug]pages are real, crawlable pages with their owngenerateStaticParams, but were silently excluded from the sitemap — hurting their discoverability in search. The route also trusted the requestHostheader to build canonical URLs, which is inconsistent with the rest of the app and forced the route off static generation on every request.Breaking Changes
None.
Screenshots
Not applicable — no UI change.
Checklist
pnpm checkpasses locally — not run in this environment (dependencies not installed); please verify in CIpnpm buildpasses locally — not run in this environment (dependencies not installed); please verify in CIpnpm build:registrywas run and the generated files are committed — not applicable, noregistry/orconfig/site.tschanges