fix(feishu): report real connection state and diagnostics - #6
Merged
Merged
Conversation
Derive status from the SDK WebSocket lifecycle instead of monitor presence. Preserve authentication and reconnect failures for channel diagnostics, clear them after recovery, and keep commands consistent with account state. Pin the tested Lark SDK, prepare Feishu 0.2.1, and run plugin regressions in CI. Verified 153 tests, typecheck, build, translations, and the original invalid-credential and disconnect probes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feishu reported a channel as connected as soon as its monitor existed, even when credentials were invalid or the WebSocket had disconnected. Connection failures also lacked diagnostic details.
Use the SDK's actual WebSocket lifecycle to report connection state, preserve authentication and reconnect errors, and clear diagnostics after recovery. Count only connected accounts and use the same state for
/feishu statusand account listings. Add localized connection states in all six supported languages.Prepare Feishu 0.2.1, pin the tested Lark SDK to 1.73.3, and run plugin regression tests in CI.
Validation:
10014 / app id not exists; a local WebSocket disconnect reports disconnected with nonempty diagnostics.