Stochastic noise extensions - #2442
Conversation
maxwhitemet
left a comment
There was a problem hiding this comment.
Hi Gavin. This looks good to me. I've suggested some small changes.
maxwhitemet
left a comment
There was a problem hiding this comment.
Happy with the changes made. Approved 👍
mo-jbeaver
left a comment
There was a problem hiding this comment.
I've added some comments below. The unit tests passed successfully but the acceptance tests failed:
FAILED improver_tests/acceptance/test_stochastic_noise.py::test_scale_non_positive_noise - ValueError: Checksum for stochastic_noise/scaled/kgo.nc is 45940447df6131b21f66081fcb105b8d9b2e7ffe79b3db7c97791eafab0e2d88, expected 707e828564189398fb705eeafeff94ba368714697bfe20f22dfe6a8f67cc2616 in /home/users/jasmine.beaver/impr... FAILED improver_tests/acceptance/test_stochastic_noise.py::test_dry_realizations[False] - clize.errors.UnknownOption: improver stochastic-noise: Unknown option '--wet-noise-floor'. Did you mean '--non-positive-noise-floor'? FAILED improver_tests/acceptance/test_stochastic_noise.py::test_dry_realizations[True] - clize.errors.UnknownOption: improver stochastic-noise: Unknown option '--wet-noise-floor'. Did you mean '--non-positive-noise-floor'? FAILED improver_tests/acceptance/test_stochastic_noise.py::test_positive_regions[False] - clize.errors.UnknownOption: improver stochastic-noise: Unknown option '--wet-noise-amplitude'. Did you mean '--positive-region-noise-amplitude'? FAILED improver_tests/acceptance/test_stochastic_noise.py::test_positive_regions[True] - clize.errors.UnknownOption: improver stochastic-noise: Unknown option '--wet-noise-amplitude'. Did you mean '--positive-region-noise-amplitude'?
Accidently approved instead of requesting changes.
9a16ad0 to
bb0c76e
Compare
mo-jbeaver
left a comment
There was a problem hiding this comment.
Happy with the updates made and all tests passed successfully.
8106caa to
3fbc6fb
Compare
mo-jbeaver
left a comment
There was a problem hiding this comment.
Happy with the changes made and all tests passed successfully.
…sion * upstream/master: Spatial morphing (metoppv#2441) Stochastic noise extensions (metoppv#2442) Forecast capping if calibrate forecast is too far from the uncalibrated (metoppv#2449) Vicinity metadata from the threshold plugin (metoppv#2439) Update cluster sources bookkeeping, so that forecast periods are only stored in one forecast source. (metoppv#2437) Correct realization numbering bug in temporal interpolation (metoppv#2436) Modify precedence ordering when clustering (metoppv#2435)
* master: Spatial Morphing - refinement of Google FILM output (#2451) Spatial morphing (#2441) Stochastic noise extensions (#2442) Forecast capping if calibrate forecast is too far from the uncalibrated (#2449) Vicinity metadata from the threshold plugin (#2439) Update cluster sources bookkeeping, so that forecast periods are only stored in one forecast source. (#2437)
Related to https://github.com/metoppv/mo-blue-team/issues/1268
improver_test_data PR: metoppv/improver_test_data#147
Description
This PR extends the stochastic noise implementation with two main aims:
The stochastic noise values created by pysteps can sometimes be quite large (up to 5 mm/hr), so a wet-noise-amplitude multiplier is added, so that the stochastic noise can be controlled, so that it adds some small-scale variability, without markedly changing the original forecast.
Testing: