Repository navigation
Feat/proanimer - #23
Open
drowning-in-codes wants to merge 14 commits into
Open
drowning-in-codes wants to merge 14 commits into
drowning-in-codes wants to merge 14 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Vercel entrypoints are incompatible with classic serverless functions, and prefix-boundary routing and test-count documentation also need correction.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds RESTful routing and shared Bun/Vercel deployment support while preserving legacy API endpoints.
Changes:
- Adds shared routing, authentication, API handling, and Vercel entrypoints.
- Adds caching, cookie behavior, rewrites, and tests.
- Updates documentation, tooling, and migration plans.
| File | Summary |
|---|---|
vercel.json |
Adds the /demo rewrite. |
test/router.test.js |
Tests route parsing. |
test/lyric.test.js |
Tests lyric formatting. |
test/auth.test.js |
Tests authentication. |
test/api.test.js |
Tests API contracts. |
src/utils/cookie.js |
Handles serverless cookies. |
src/service/auth.js |
Provides HMAC authentication. |
src/service/api.js |
Refactors API resolution and caching. |
src/router.js |
Adds legacy and RESTful routing. |
src/index.js |
Uses the shared Bun handler. |
src/config.js |
Adds Vercel URL fallback configuration. |
src/app.js |
Provides shared request handling and CORS. |
README.md |
Documents RESTful and Vercel usage. |
package.json |
Adds the test script. |
docs/superpowers/specs/2026-09-27-vercel-restful-migration-design.md |
Adds the migration design. |
docs/superpowers/plans/2026-09-27-vercel-restful-migration.md |
Adds the implementation plan. |
CLAUDE.md |
Updates architecture guidance. |
api/index.js |
Defines the Vercel root entrypoint. |
api/[...path].js |
Defines the Vercel catch-all entrypoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+5
to
+6
| export const GET = app | ||
| export const OPTIONS = app |
Comment on lines
+5
to
+6
| export const GET = app | ||
| export const OPTIONS = app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.