Repository navigation
[SM6.10] Add missing linalg.h include guard - #9070
Merged
Merged
Conversation
Damyan Pepper (damyanp)
approved these changes
Oct 22, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The behavioral fix lacks the regression test required by the repository’s contribution policy.
1 open issue
What changed in this PR
Fixes #9061 by making DXC’s SM 6.10 Linear Algebra header safe to include multiple times.
Changes:
- Wraps the entire header in
_HLSL_DX_LINALG_H_include guards. - Preserves the existing shader-model and HLSL-version checks.
Please add a double-include regression test with SM 6.10 and HLSL 2021 enabled.
| File | Description |
|---|---|
| tools/clang/lib/Headers/hlsl/dx/linalg.h | Adds an include guard to prevent redefinition errors. |
Review effort: Balanced
Comment on lines
+12
to
+13
| #ifndef _HLSL_DX_LINALG_H_ | ||
| #define _HLSL_DX_LINALG_H_ |
Deric C. (Icohedron)
approved these changes
Oct 22, 2026
Chris B (llvm-beanz)
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9061