Repository navigation
FIX: key model-less objective targets by content hash in analytics v1 - #3171
Merged
Roman Lutz (romanlutz) merged 5 commits intoOct 16, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: db31a497-470d-44b7-ac37-934ab6362724
Match Python str.strip when choosing model-less target labels on SQLite and SQL Server. Cover normalized and embedded identifiers through SDK reports, facets, matrices, and drill-downs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: db31a497-470d-44b7-ac37-934ab6362724
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: db31a497-470d-44b7-ac37-934ab6362724
Roman Lutz (romanlutz)
approved these changes
Oct 16, 2026
Move the label regression into the analytics suite and reuse its finite correctness budgets. Keep real SQLite, all identity assertions, and production timeout defaults unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: db31a497-470d-44b7-ac37-934ab6362724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analytics keyed objective targets by model name, temperature and top_p, so every target without a model name (HTTP, Gandalf and so on) got lumped into one unlabeled group per class. As Roman suggested, this corrects v1 instead of adding a v2. Targets with a model name keep their key, and the rest fall back to their content hash with a readable label like HTTPTarget instead of a blank one.
A new migration reruns the v1 backfill, so databases that already ran the old one get the fixed keys too. The tests cover different HTTP endpoints and Gandalf levels, blank model names, wrappers and an already migrated database.
Fixes #3087