Repository navigation
Fix Rust MSVC debug CRT mismatch - #895
Merged
Matthew Parkinson (mjp41) merged 2 commits intoNov 2, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes aligning snmalloc’s Windows CRT selection with Rust.
No open issues 🎉
What changed in this PR
Fixes #894 by aligning snmalloc’s Windows MSVC runtime selection with Rust, avoiding mixed debug and release CRTs in Rust debug builds.
Changes:
- Selects static or dynamic CRT linking based on Rust’s
crt-statictarget feature. - Keeps CMake Debug builds on the release CRT and removes explicit
msvcrtdlinking. - Updates the Rust bindings documentation to describe CRT selection.
| File | Description |
|---|---|
snmalloc-rs/snmalloc-sys/build.rs |
Aligns CRT selection with Rust and removes debug CRT linking. |
snmalloc-rs/README.md |
Documents dynamic CRT defaults and crt-static behavior. |
Review effort: Balanced
Contributor
Author
|
failed check is unrelated to my changes |
Matthew Parkinson (mjp41)
approved these changes
Nov 2, 2026
Matthew Parkinson (mjp41)
left a comment
Matthew Parkinson (mjp41)
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks
Matthew Parkinson (mjp41)
enabled auto-merge (squash)
November 2, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #894
Summary
crt-statictarget feature.MSVCRTD.msvcrtdlink directive for Rust MSVC builds.Testing
cargo test --manifest-path snmalloc-rs/Cargo.toml --allcrt-staticenabled.Both complete without LNK4098.