Repository navigation
Fix refresh-to-empty bug and reduce refreshes - #9035
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new lock can discard refreshes during active fetches and unnecessarily blocks independent workspace folders.
2 open findings
What changed in this PR
Fixes tree refresh races and removes redundant refresh events.
Changes:
- Serializes overlapping “All Open” requests.
- Consolidates configuration and active-PR refresh handling.
- Adds concurrency and refresh-notification tests.
| File | Description |
|---|---|
src/view/treeNodes/pullRequestNode.ts |
Removes per-node refresh listeners. |
src/view/prsTreeModel.ts |
Adds request serialization. |
src/view/prsTreeDataProvider.ts |
Centralizes refresh handling. |
src/test/view/prsTree.test.ts |
Tests concurrency and refresh behavior. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Alex Ross (alexr00)
marked this pull request as draft
October 8, 2026 09:39
auto-merge was automatically disabled
October 8, 2026 09:39
Pull request was converted to draft
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The concurrency fix is well-scoped and comprehensively covered by regression tests.
0 open findings
2 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Martin Aeschlimann (aeschli)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.