Skip to content

fix(android): name a crash after its first frame outside the platform #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mobile-kevin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): name a crash after its first frame outside the platform #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions devices/android_crash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,17 +187,54 @@ func parseJavaCrash(lines []string, start int) (*CrashReport, int) {
}, i
}

// platformFramePrefixes are the packages of the runtime and libraries an app
// is built on. An exception often surfaces in one of them (android.os.Parcel,
// java.lang.Integer), which says nothing about which program crashed.
var platformFramePrefixes = []string{
"android.",
"androidx.",
"com.android.internal.",
"dalvik.",
"java.",
"javax.",
"jdk.internal.",
"kotlin.",
"kotlinx.",
"libcore.",
"sun.",
}

func isPlatformFrameOwner(owner string) bool {
for _, prefix := range platformFramePrefixes {
if strings.HasPrefix(owner, prefix) {
return true
}
}
return false
}

// extractProcessFromStack names a crash that has no "Process:" line after the
// class of its first stack frame outside the platform, falling back to the
// first frame when every frame belongs to the platform.
func extractProcessFromStack(lines []string, start int, pid string) string {
firstOwner := ""
for i := start + 1; i < len(lines); i++ {
parsed := parseLogcatLine(lines[i])
if parsed == nil || parsed.PID != pid || parsed.Tag != androidRuntimeTag {
break
}
if name := parseStackFrameOwner(parsed.Message); name != "" {
name := parseStackFrameOwner(parsed.Message)
if name == "" {
continue
}
if !isPlatformFrameOwner(name) {
return name
}
if firstOwner == "" {
firstOwner = name
}
}
return ""
return firstOwner
}

// parseStackFrameOwner extracts the fully qualified class name from a stack
Expand Down
46 changes: 46 additions & 0 deletions devices/android_crash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,52 @@ func TestJavaCrashWithConstructorFrame(t *testing.T) {
assert.Equal(t, "com.example.myapp.MyService", crashes[0].ProcessName)
}

// a uiautomator crash taken from an emulator: the exception surfaces in the
// framework, and the crashing program's own code is further down the stack
const uiautomatorCrashLog = `2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: FATAL EXCEPTION: main
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: PID: 30490
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: java.lang.IllegalStateException: UiAutomationService android.accessibilityservice.IAccessibilityServiceClient$Stub$Proxy@d09dec2already registered!
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at android.os.Parcel.createExceptionOrNull(Parcel.java:3348)
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at android.os.Parcel.createException(Parcel.java:3324)
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at android.view.accessibility.IAccessibilityManager$Stub$Proxy.registerUiTestAutomationService(IAccessibilityManager.java:1154)
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at android.app.UiAutomation.connect(UiAutomation.java:331)
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at com.android.uiautomator.core.UiAutomationShellWrapper.connect(UiAutomationShellWrapper.java:36)
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at com.android.commands.uiautomator.DumpCommand.run(DumpCommand.java:78)
2026-10-03 00:43:17.468 30490 30490 E AndroidRuntime: at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:371)`

func TestJavaCrashWithoutProcessLineSkipsFrameworkFrames(t *testing.T) {
crashes := ParseAndroidCrashLog(uiautomatorCrashLog)

require.Len(t, crashes, 1)
assert.Equal(t, "com.android.uiautomator.core.UiAutomationShellWrapper", crashes[0].ProcessName)
}

func TestJavaCrashSkipsJavaAndKotlinFramesToFindTheAppFrame(t *testing.T) {
log := `2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: FATAL EXCEPTION: main
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: java.lang.NumberFormatException: For input string: "x"
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: at java.lang.Integer.parseInt(Integer.java:797)
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: at kotlin.text.StringsKt__StringNumberConversionsJVMKt.toInt(StringNumberConversionsJVM.kt:10)
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: at androidx.fragment.app.Fragment.performCreate(Fragment.java:3094)
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: at com.example.myapp.SettingsFragment.onCreate(SettingsFragment.kt:21)`

crashes := ParseAndroidCrashLog(log)

require.Len(t, crashes, 1)
assert.Equal(t, "com.example.myapp.SettingsFragment", crashes[0].ProcessName)
}

func TestJavaCrashWithOnlyFrameworkFramesFallsBackToTheFirstFrame(t *testing.T) {
log := `2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: FATAL EXCEPTION: main
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: java.lang.RuntimeException
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: at android.os.Looper.loop(Looper.java:288)
2026-03-27 14:00:00.000 12345 12345 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1004)`

crashes := ParseAndroidCrashLog(log)

require.Len(t, crashes, 1)
assert.Equal(t, "android.os.Looper", crashes[0].ProcessName)
}

func TestExtractedNativeCrashDoesNotIncludeJavaCrash(t *testing.T) {
content, err := ExtractAndroidCrash(sampleCrashLog, "2026-03-02_10:58:32.108_1300")

Expand Down