Repository navigation
ci: fix kilted branch CI to actually test against kilted - #3769
Merged
Merged
Conversation
When the kilted branch was forked from main, two workflow files were overlooked and still target rolling/humble/jazzy: 1. .github/workflows/ci.yaml's matrix was testing kilted-branch code against rolling-ci/humble-ci/jazzy-ci images. PR CI thus failed for reasons unrelated to the PR (e.g. mergify-backported moveit#3768 failed all 6 jobs because they ran on rolling+humble+jazzy infrastructure that doesn't match kilted's expected toolchain). 2. .github/workflows/docker.yaml's matrix kept ROS_DISTRO=[rolling], so the kilted branch never built its own moveit/moveit2:kilted-ci / kilted-release / kilted-source images. The push trigger also still pointed at branches: [main]. Match the jazzy branch's pattern: ci.yaml uses kilted-ci for both ccov and ikfast+clang-tidy jobs; docker.yaml builds kilted images and triggers on pushes to kilted. Followup work after this lands: - Trigger docker.yaml manually (workflow_dispatch on kilted) to build the first set of kilted-ci/release/source Docker images, OR push any commit to kilted to trigger automatically. - Once moveit/moveit2:kilted-ci exists, re-run CI on PR moveit#3768 (and any other open kilted backports) so they have a real toolchain to test against. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
|
Please target the |
nbbrooks
added a commit
to nbbrooks/moveit2
that referenced
this pull request
Jun 23, 2026
…sections Document the unified per-distro branch CI policy established by: - Topic 3 §"Per-distro branches": which workflows live on per-distro branches (ci/docker/docker_lint/format only) vs main-only (prerelease/sonar/stale/tutorial_docker). - Topic 3 §"Forking a new per-distro branch": the exact bootstrap changes when a new ROS distro lands. Captures the lessons from the kilted-branch retrofit (moveit#3769) where ci.yaml/docker.yaml/tutorial workflows were left targeting rolling/main after the fork from main. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the kilted branch was forked from main, two workflow files were overlooked and still target rolling/humble/jazzy:
.github/workflows/ci.yaml's matrix was testing kilted-branch code against rolling-ci/humble-ci/jazzy-ci images. PR CI thus failed for reasons unrelated to the PR (e.g. mergify-backported Fix ERROR stream + check only active controllers for multiple chained controllers (backport #3556) #3768 failed all 6 jobs because they ran on rolling+humble+jazzy infrastructure that doesn't match kilted's expected toolchain).
.github/workflows/docker.yaml's matrix kept ROS_DISTRO=[rolling], so the kilted branch never built its own moveit/moveit2:kilted-ci / kilted-release / kilted-source images. The push trigger also still pointed at branches: [main].
Match the jazzy branch's pattern: ci.yaml uses kilted-ci for both ccov and ikfast+clang-tidy jobs; docker.yaml builds kilted images and triggers on pushes to kilted.
Followup work after this lands:
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist