Skip to content

Replace shared_ptr unique checks (backport #3793) - #3890

Open
mergify[bot] wants to merge 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-3793
Open

mergify[bot] wants to merge 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-3793

Conversation

@mergify

@mergify mergify Bot commented Sep 28, 2026

Copy link
Copy Markdown

This is part of an effort to contribute RoboStack downstream patches back upstream.

Origin: focused portions of patch/ros-rolling-moveit-core.patch, patch/ros-rolling-moveit-planners-ompl.patch, and patch/ros-rolling-moveit-ros-planning.patch, authored by Daisuke Nishimatsu.

std::shared_ptr::unique() was removed in C++20. This replaces the remaining source-level ownership checks with equivalent use_count() comparisons while preserving the existing logic.

This intentionally leaves moveit_ros/robot_interaction untouched because that file is already covered by #3792.


This is an automatic backport of pull request #3793 done by [Mergify](https://mergify.com).

std::shared_ptr::unique() is removed in C++20. Use use_count() comparisons instead while preserving the existing ownership checks.

Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Co-authored-by: Daisuke Nishimatsu <nishimarudai@gmail.com>
(cherry picked from commit f737f20)
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9f1a8f65-8965-4645-bd40-d5833c52d369

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@130s
130s requested a review from rhaschke September 28, 2026 15:22
@130s

130s commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Although I made this PR, for this one particularly I'm just not so sure if backporting (to jazzy or any older distros) makes sense.

@130s 130s mentioned this pull request Sep 28, 2026
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.24%. Comparing base (a73060f) to head (923daa2).

Files with missing lines Patch % Lines
moveit_core/robot_state/src/attached_body.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3890      +/-   ##
==========================================
- Coverage   46.28%   46.24%   -0.03%     
==========================================
  Files         718      718              
  Lines       59182    59187       +5     
  Branches     7600     7599       -1     
==========================================
- Hits        27387    27367      -20     
- Misses      31630    31656      +26     
+ Partials      165      164       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants