Replace shared_ptr unique checks (backport #3793) - #3890
mergify[bot] wants to merge 1 commit into
Conversation
std::shared_ptr::unique() is removed in C++20. Use use_count() comparisons instead while preserving the existing ownership checks. Signed-off-by: Tobias Fischer <info@tobiasfischer.info> Co-authored-by: Daisuke Nishimatsu <nishimarudai@gmail.com> (cherry picked from commit f737f20)
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Although I made this PR, for this one particularly I'm just not so sure if backporting (to jazzy or any older distros) makes sense. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jazzy #3890 +/- ##
==========================================
- Coverage 46.28% 46.24% -0.03%
==========================================
Files 718 718
Lines 59182 59187 +5
Branches 7600 7599 -1
==========================================
- Hits 27387 27367 -20
- Misses 31630 31656 +26
+ Partials 165 164 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: focused portions of
patch/ros-rolling-moveit-core.patch,patch/ros-rolling-moveit-planners-ompl.patch, andpatch/ros-rolling-moveit-ros-planning.patch, authored by Daisuke Nishimatsu.std::shared_ptr::unique()was removed in C++20. This replaces the remaining source-level ownership checks with equivalentuse_count()comparisons while preserving the existing logic.This intentionally leaves
moveit_ros/robot_interactionuntouched because that file is already covered by #3792.This is an automatic backport of pull request #3793 done by [Mergify](https://mergify.com).