Skip to content

Show unread counts in tag chips - #7068

Open
mahibi wants to merge 3 commits into
masterfrom
showNumbersInTagChips
Open

mahibi wants to merge 3 commits into
masterfrom
showNumbersInTagChips

Conversation

@mahibi

@mahibi mahibi commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Shows unread counts in the conversation tag chips, like the iOS app (nextcloud/talk-ios#2621).

The number on a tag chip is the number of conversations in that tag with unread messages, not the number of unread messages. The favorites chip counts unread favorite conversations. The "All" chip has no number.

The badge uses the same styles as the unread bubble of a conversation. A chip uses the most important style among its unread conversations:

  • filled: direct mention, or an unread one-to-one conversation
  • outlined: group mention only
  • grey: unread messages without a mention

Round badges for single digits

The unread bubble is moved into a shared UnreadCountBadge composable. It is now round for single digit numbers, which also applies to the badges in the conversation list.

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Each tag chip shows how many of its conversations have unread messages,
like the iOS app does. The number counts conversations, not unread
messages. The favorites chip counts unread favorite conversations.

The badge uses the same styles as the unread bubble of a conversation:
filled for a direct mention or an unread one-to-one conversation,
outlined for a group mention and grey otherwise. A chip uses the most
important style among its unread conversations. To share the styles,
the unread bubble is moved into its own composable.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
The unread badge was a bit wider than tall for single digit numbers.
Make it at least as wide as tall and fully rounded, so single digits
show as a circle and longer numbers as a pill. This applies to the tag
chips and the conversation items.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added this to the 26.0.0 milestone Nov 18, 2026
@mahibi mahibi self-assigned this Nov 18, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Nov 18, 2026
@mahibi mahibi changed the title Show numbers in tag chips Show unread counts in tag chips Nov 18, 2026
Count each conversation only once per tag chip, even if the room list
contains it twice, so the count matches the filtered list.

Hiding tags without conversations is now done while building the
chips, instead of in a second pass over all rooms with a copy of the
tag matching rule.

Skip the capability lookup for the unread bubble of read
conversations, and use the nullable capability check in the screen.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
mahibi force-pushed the showNumbersInTagChips branch from eb985b3 to 1d47031 Compare November 18, 2026 12:10
@mahibi
mahibi marked this pull request as ready for review November 18, 2026 12:12
@mahibi
mahibi requested a review from rapterjet2004 November 18, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant