Repository navigation
fix(web-app, observation): Angular 21+ modernizing for part 2 of observation-edit - #609
Conversation
…effect The geometry form started an edit session from an effect on its feature input. The effect read currentFeature, so any write to it re-ran the effect. FeatureEditor calls geometryChanged synchronously when it is created for a point, and that write re-ran the effect, which created another editor, in an endless loop that hung the browser when opening the geometry editor. Map drags and vertex edits also re-ran it, losing the drag, resetting the selected vertex and stacking feature editors. Replace the feature input and effect with a startEdit() method that the geometry component calls from startGeometryEdit().
|
Found a regression while testing: clicking the expand/collapse chevron on a form card reloads the whole page. Cause: before this PR, Suggested fix: the - <form class="observation" name="observationForm" novalidate>
+ <div class="observation">
...
- </form>
+ </div>Importing |
|
Pre-existing, something I found in testing, since we're in here: on a network failure (offline, blocked, CORS) const error = event.response?.error;
this.snackBar.open(typeof error === 'string' ? error : 'Unable to upload attachment.', undefined, { duration: 4000 }); |
newmanw
left a comment
There was a problem hiding this comment.
Thanks, the updates look good. One leftover: closed moved to output(), but the other outputs in the folder are still @Output() ... = new EventEmitter(). Can these move too?
observation-edit-form.component.ts:57-58:remove,featureEditobservation-edit-geometry.component.ts:32:featureEditobservation-edit-geometry-form.component.ts:80-81:save,cancelobservation-edit-geometry-map.component.ts:14:onEdit
|



Summary
Converts the observation-edit components to standalone / signals / modern control flow as part of the Angular 21 migration.
Testing
Manual Web-Side Testing