Change the default field resolver #2191

Activity

1. spawnia

   added

   discussionRequires input from multiple peopleRequires input from multiple people

   on Aug 4, 2022
2. olivernybroe commented on Feb 6, 2023

   

   olivernybroe

   on Feb 6, 2023

   Collaborator

   More actions

   I think this could be a great idea and something that would improve performance greatly.

   I have however tried to also submit a pr to Laravel with the issue itself as webonyx/graphql is prob. not the only package relying on ArrayAccess being implemented correctly. laravel/framework#45976
3. pyrou commented on Mar 2, 2023

   

   pyrou

   on Mar 2, 2023

   Collaborator

   More actions

   I am using for while now the following "DefaultResolver":

   <?php
   
   namespace App\GraphQL\Resolvers;
   
   use ArrayAccess;
   use Closure;
   use GraphQL\Type\Definition\ResolveInfo;
   use Illuminate\Support\Str;
   use Nuwave\Lighthouse\Support\Contracts\GraphQLContext;
   
   class DefaultResolver
   {
       public function __invoke(mixed $parent, $args, GraphQLContext $context, ResolveInfo $resolveInfo): mixed
       {
           $fieldName = $resolveInfo->fieldName;
           $snakeFieldName = Str::snake($fieldName);
           
           $value = $this->getFieldValue($parent, $fieldName);
           
           if ($value === null && $snakeFieldName !== $fieldName) {
               // Give a chance to resolve field using the snake case
               $value = $this->getFieldValue($parent, $snakeFieldName);
           }
   
           return $value instanceof Closure ? $value($parent, $args, $context, $resolveInfo) : $value;
       }
   
       protected function getFieldValue(mixed $parent, string $fieldName): mixed
       {
           if (is_array($parent) || $parent instanceof ArrayAccess) {
               return $parent[$fieldName] ?? null;
           }
           if (is_object($parent) && isset($parent->{$fieldName})) {
               return $parent->{$fieldName};
           }
   
           return null;
       }
   }

   It is plugged into lighthouse with Executor::setDefaultFieldResolver($defaultResolver);

   It mainly address the @rename overuse.

   If this get you some idea for a new default resolver on Lighthouse 6 😉
4. nuwave

   deleted a comment from chojnicki on Jun 30, 2024
5. spawnia commented on Jun 12, 2025

   

   spawnia

   on Jun 12, 2025

   CollaboratorAuthor

   More actions

   I have created #2693 as a potential solution to this issue and the issues mentioned within. If you are watching this space, please take a look and provide feedback there.