Skip to content

Update quantitative.js #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dwood0307work-ai wants to merge 1 commit into from
Closed

Update quantitative.js #2465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/scales/quantitative.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,19 @@ export function createScaleQ(
if (zero) {
const [min, max] = extent(domain);
if (min > 0 || max < 0) {
// preserve polylinear domain order and avoid mutating input
domain = slice(domain);
const o = orderof(domain) || 1; // treat degenerate as ascending
if (o === Math.sign(min)) domain[0] = 0; // [1, 2] or [-1, -2]
else domain[domain.length - 1] = 0; // [2, 1] or [-2, -1]
// Determine ascending (true) or descending (false) ordering of domain array
const ascending = orderof(domain) >= 0; // treat degenerate as ascending
// If domain is all positive, ensure the lower bound is zero; if all
// negative, ensure the upper bound is zero. Respect ascending/descending
// by writing to the appropriate end of the domain array.
if (min > 0) {
if (ascending) domain[0] = 0; else domain[domain.length - 1] = 0;
} else {
// max < 0
if (ascending) domain[domain.length - 1] = 0; else domain[0] = 0;
}
}
}

Expand Down