Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
|
Unfortunately, this is not a good fit. It doesn't seem to have paid a lot of attention to #14 (comment) , and is not searching to connect the I'm not sure if they constants declarations are really necessary are they? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did: the issue is a one-liner that points at an upstream PR in eschnett/mpi_abi_wrapper. That PR adds the GPU-support queries to that project. I decided traMPI should do the same.
Testing: I generated the proxy, compiled it, and ran it against a fake backend that exports only the CUDA and ROCm queries. The results were correct. pytest isn't installed here, so I ran only the new test, by hand; I didn't run the full suite. I haven't tried it against real MPICH
or Open MPI, or on a GPU.
Doubts:
I initialised the git submodules to run the generator. That left the working tree changed, but I didn't commit those changes.
Disclaimer: fully generated by Claude, at the request of @ocaisa