Repository navigation
Yet more GHA issues - #1733
Merged
Merged
Yet more GHA issues#1733
Conversation
… whole workflow does not fire unless it's a PR. Also fixed some comment formatting.
gregorydlogan
added
type:bug
|
This pull request is deployed at test.editor.opencast.org/ . |
Member
Author
|
Welp, the comment posts, but the URL and contents are wrong. So yeah, this will need to get merged all the way forwards once I've corrected that. |
… just the number since we need the full path for the comment made by the bot. PR number itself is now extracted from that build path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the GHA script which was failing to correctly deploy the built PR branches due to an incorrect (and unneccessary) check. This will need to be merged forward to
developto take effect, but I'd like to keep all the scripts in sync if we can.