Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 1 1
Lines 542 542
=======================================
Hits 510 510
Misses 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
13d74b7 to
b19f6e6
Compare
Build Android arm64_v8a and x86_64 wheels with CPython 3.13+. Download prebuilt libzim Android binaries and adjust packaging/rpaths for Android toolchain. Add opt-in Android job to CI wheels workflow. Closes openzim#167
b19f6e6 to
119d620
Compare
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Build Android wheels |
There was a problem hiding this comment.
why is this working straight on ubuntu-26.04 while we have to setup QEMU for normal linux wheels? Should we drop QEMU from normal linux wheels?
There was a problem hiding this comment.
Android wheels are cross-compiled with the NDK on the host, so nothing arm64 has to run and QEMU is not involved. The Linux aarch64 wheels are different: cibuildwheel builds them inside an arm64 manylinux container, so on an x86_64 runner QEMU is what allows that container to run at all. Dropping QEMU would only work with native arm64 runners (or by cross-compiling Linux aarch64 ourselves), so I would keep it for the Linux job.
|
Addressed the review feedback.
|
3c648f6 to
0370d96
Compare
|
hit a blocker while getting the Android wheel to actually build: the published Android libzim binaries are reader-only, so the extension cannot link its writer bindings. Evidence (arm64 archives from
Linux/macOS archives still ship the writer headers and symbols.
Options:
|
38bd5e0 to
0370d96
Compare
|
@kelson42 any reason to have limited Android libzim builds to "reader-only"? Where should I open an issue? |
Build Android and wheels with CPython 3.13+. Download prebuilt libzim Android binaries, adjust packaging/rpaths for Android toolchain. Add opt-in Android job to wheels CI.
thanks to @benoit74 for suggestion
Closes #167