You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
save_large_file should use default user-agent and accept arbitrary headers #360
Hi! I'd like to work on this issue. I'll look at how #353 fixed stream_file and apply the same approach to save_large_file, plus add support for custom headers. Is it okay if I take it?
@pawank925 I appreciate you moving fast, but pushing a PR to an issue already assigned to a volunteer which recently commit to work on it is a bit rude, looks like hijacking to me. I really want to maintain a welcoming community and give everyone a chance to contribute, no matter how fast or good they are (with some boundaries of course). Please do not close PR for now since work is done, but let's see where we are.
@adityahabib where are you on implementation of this issue?
@benoit74 really sorry previoulsy i worked on stream_file so i thought implementing save_large_file is an importnat one as well apolozies and i have worked one it 10 hrs again anyhow if you order i will close it @adityahabib sorry as well
You definitely deserve to be assigned this issue, I just want to avoid double work on same issue + not letting other people work at their pace ; I do really appreciate all the hard work you've already pushed in our community
Activity
adityahabib commentedon Oct 22, 2026
Hi! I'd like to work on this issue. I'll look at how #353 fixed stream_file and apply the same approach to save_large_file, plus add support for custom headers. Is it okay if I take it?
benoit74 commentedon Oct 22, 2026
@adityahabib please push a PR
Send default User-Agent and accept headers in save_large_file
benoit74 commentedon Oct 22, 2026
@pawank925 I appreciate you moving fast, but pushing a PR to an issue already assigned to a volunteer which recently commit to work on it is a bit rude, looks like hijacking to me. I really want to maintain a welcoming community and give everyone a chance to contribute, no matter how fast or good they are (with some boundaries of course). Please do not close PR for now since work is done, but let's see where we are.
@adityahabib where are you on implementation of this issue?
pawank925 commentedon Oct 22, 2026
@benoit74 really sorry previoulsy i worked on stream_file so i thought implementing save_large_file is an importnat one as well apolozies and i have worked one it 10 hrs again anyhow if you order i will close it @adityahabib sorry as well
and i will be in control now ownwards sorry!
benoit74 commentedon Oct 22, 2026
You definitely deserve to be assigned this issue, I just want to avoid double work on same issue + not letting other people work at their pace ; I do really appreciate all the hard work you've already pushed in our community