Repository navigation
Conversation
schutzbot
requested review from
achilleas-k,
brlane-rht and
supakeen
and removed request for
a team
October 18, 2026 15:01
supakeen
approved these changes
Oct 19, 2026
Member
@supakeen I assume this is related to osbuild/osbuild@d664919 |
Member
That's definitely related; the 'bugfix' did in fact narrow it for cases where there are non-alphanumerics. Which side do we want to fix this on? We can re-widen the Since we haven't actually done an |
Member
SGTM |
croissanne
pushed a commit
to osbuild/osbuild
that referenced
this pull request
Oct 21, 2026
RHEL installers (at least `bootc`-based ones) historically have used dots in their volume IDs. Expand the regular expression to allow for this. See [1]. [1]: osbuild/bootc-foundry#162 (comment) Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating images library ref to current
mainChanges: osbuild/image-builder@dd0e7d9...1b26ffb