Repository navigation
Conversation
… trade-offs The former "Split Package Compatibility" and "Issues With Requiring Bundles" sections mixed three separate topics. The "compatibility" title suggested backward compatibility, "subset" was undefined, and the split package drawbacks hid behind a generic "issues" heading, so readers not using split packages saw no reason to avoid Require-Bundle. Split the text into three sections: - Split Packages: definition, sources, what "compatible" means with an example, legitimate reasons for split packages, a recommendation and the drawbacks. - Re-exporting Required Bundles: presented as a compatibility bridge for refactorings (moving a package to a new bundle without breaking existing Require-Bundle clients), with its own drawbacks. - Require-Bundle versus Import-Package: acknowledges the historic practice and valid use cases, lists drawbacks (coupling, coarse versioning, open ended content, ordering, fixed provider, shadowing) and recommends Import-Package where possible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
@tjwatson @timothyjward @maho7791 Do we all agree that this just explains the spec better and does not change the spec in any way? If so i would merge this next spec meeting 18.11.2026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
"Split Package Compatibility" and "Issues With Requiring Bundles" mixed three topics: split packages, re-export and Require-Bundle itself.
The title suggested backward compatibility, "subset" was undefined, and the split-package drawbacks were hard to connect to Require-Bundle.
Changes
Not changed
Existing drawback items (Completeness, Ordering, Performance, Confusing) and the example in Require-Bundle are kept as they were.
Please review
I tried to generate a diff spec PDF here: changes-highlighted.pdf