Skip to content

[1/n] [downloader] dedupe helpers, fix error-message bugs - #11416

Closed
sunshowers wants to merge 1 commit into
mainfrom
jj-stack/1-n-downloader-dedupe-helpers-fix-error-message-bugs-qzqloqwr
Closed

sunshowers wants to merge 1 commit into
mainfrom
jj-stack/1-n-downloader-dedupe-helpers-fix-error-message-bugs-qzqloqwr

Conversation

@sunshowers

Copy link
Copy Markdown
Contributor

Preparatory cleanups for #11102:

  • Merge clickhouse_confirm_binary_works and cockroach_confirm_binary_works into a single confirm_binary_works.
  • Don't discard stderr if it isn't valid UTF-8.
  • Include stdout in the failure message.
  • Add a read_version_file helper.
  • Fix a bug where we had .context("Failed to read version from {versions_path}") which wouldn't interpolate versions_path.
    • Turns out the non-interpolating bug is covered by the literal_string_with_formatting_args clippy lint -- turn that on.
    • This found a bunch of other instances, most of which were genuine (though a few were false positives) -- fix and exclude them as appropriate.
  • Reject empty version files as a programmer error.
  • Include the file path in the get_values_from_file missing-keys error.
  • In flake.nix, make findSha throw with an actionable message when a checksum entry is missing, instead of silently returning "".

Pull Request: #11103

Preparatory cleanups for #11102:

* Merge `clickhouse_confirm_binary_works` and `cockroach_confirm_binary_works`
  into a single `confirm_binary_works`.
* Don't discard stderr if it isn't valid UTF-8.
* Include stdout in the failure message.
* Add a `read_version_file` helper.
* Fix a bug where we had `.context("Failed to read version from {versions_path}")` which wouldn't interpolate `versions_path`.
  * Turns out the non-interpolating bug is covered by the `literal_string_with_formatting_args` clippy lint -- turn that on.
  * This found a bunch of other instances, most of which were genuine (though a few were false positives) -- fix and exclude them as appropriate.
* Reject empty version files as a programmer error.
* Include the file path in the `get_values_from_file` missing-keys error.
* In flake.nix, make `findSha` throw with an actionable message when a checksum entry is missing, instead of silently returning "".

Pull Request: #11103
@sunshowers

Copy link
Copy Markdown
Contributor Author

Closing in favor of #11103.

@sunshowers sunshowers closed this Oct 5, 2026
@sunshowers
sunshowers deleted the jj-stack/1-n-downloader-dedupe-helpers-fix-error-message-bugs-qzqloqwr branch October 5, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant