Skip to content

[39/n] [meta] surface panics from simulated SP tasks at teardown - #11824

Draft
sunshowers wants to merge 1 commit into
sunshowers/spr/38n-nexus-test-utils-share-one-simulated-sp-rack-between-the-harnesss-two-mgs-instancesfrom
sunshowers/spr/39n-meta-surface-panics-from-simulated-sp-tasks-at-teardown
Draft

sunshowers wants to merge 1 commit into
sunshowers/spr/38n-nexus-test-utils-share-one-simulated-sp-rack-between-the-harnesss-two-mgs-instancesfrom
sunshowers/spr/39n-meta-surface-panics-from-simulated-sp-tasks-at-teardown

Conversation

@sunshowers

Copy link
Copy Markdown
Contributor

I discovered while pulling a thread as a response to
#11818 (comment)
that we were swallowing sp-sim panics rather than bubbling them up. Fix
that by collecting all errors and returning the full list as an
anyhow::Error.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant