Repository navigation
fix(sqla): support SQL expressions in AJAX lookup ordering - #2999
Open
vishalkaay wants to merge 1 commit into
Open
vishalkaay wants to merge 1 commit into
vishalkaay wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HTTP 500 errors when AJAX relation lookups use SQLAlchemy ordering expressions such as Model.name.desc(). Check explicitly for None instead of evaluating SQL expressions as booleans.
Add regression coverage for sorting, filtering, and pagination, plus documentation and a changelog entry.
Validation: 21 AJAX tests pass. The broader SQLAlchemy suite has two failures also reproduced on unchanged upstream code.
fixes #3000