Repository navigation
fix(fonts): stop retrying font downloads that cannot succeed - #822
Merged
Merged
Conversation
pamburus
force-pushed
the
fix/font-download-retry
branch
from
November 5, 2026 03:14
bd22bfc to
03b4280
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 84.64% 84.69% +0.05%
==========================================
Files 32 32
Lines 4727 4732 +5
==========================================
+ Hits 4001 4008 +7
+ Misses 726 724 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
* **Invalid or unsupported font URLs** now fail right away with a clear error instead of retrying for more than a minute * Only temporary failures, such as network errors, timeouts and `429`, `500`, `502`, `503` or `504` responses, are retried Refs: #813
pamburus
force-pushed
the
fix/font-download-retry
branch
from
November 5, 2026 03:20
03b4280 to
30c7d52
Compare
pamburus
enabled auto-merge (squash)
November 5, 2026 03:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font downloads are now retried only for temporary failures. Errors that can never succeed on retry, such as an invalid or unsupported URL, fail immediately with a clear message.
Closes #813
Verification
files = ['C:\fonts\Iosevka.ttf']) on macOSjust lintpassesjust uncoveredreports nothingBefore
After
Retrying of temporary failures was not exercised against a live failing server; it is covered by the unit tests only.