Repository navigation
Consistency: Add chip toolbar buttons to all DataView filters to match TreeViewFilter #646
Description
Activity
I picked this one up. The tree filter gets its group clear button from the
deleteLabelGroupaction on itsToolbarFilter, and the checkbox and text filters simply were not passing it, so I wired it up on both to match.One small design question before this is final. The text filter holds a single value, so its group clear ends up doing the same thing as deleting its one chip. I added it anyway to keep everything consistent like the issue asks, but if you would rather the group button only appear on the multi value filters I can scope it down. I opened a PR with tests and updated snapshots.
Hello,
During a recent PR review, we noticed that the
DataViewTreeViewFiltercontains an extra button in the chip toolbar that isn't present in other data-view filters:This is, however, as per the examples I found in PatternFly documentation, the correct behaviour for filters:
Could you please implement this behaviour to the rest of the data-view filters?
Many thanks for considering the change!
Jira Issue: PF-4106