Repository navigation
chore(deps): update rust crate tokio to v1.43.1 [security] - #253
Merged
Merged
Conversation
jmjoy
approved these changes
Oct 23, 2026
brettmc
added a commit
to brettmc/phper
that referenced
this pull request
Oct 23, 2026
A security fix only updated Cargo.lock, so phper-framework#253 moved tokio to 1.43.1 and left `tokio = "1.43.0"` in three manifests. When the requirement is a plain version, Renovate matches an alert against it rather than the lockfile (CurrentVersionMatcher in its lib/util/package-rules/current-version.ts). The alert still matched, and phper-framework#256 followed with 1.43.2. Each later tokio release would have opened another. Bump the requirement on security fixes instead. The manifest then leaves the vulnerable range and the alert stops matching after one PR. Other updates keep the lockfile-only strategy and the monthly group. This raises the tokio requirement of the published phper-test crate to the fixed version. Assisted-By: Claude Code
jmjoy
pushed a commit
that referenced
this pull request
Oct 23, 2026
A security fix only updated Cargo.lock, so #253 moved tokio to 1.43.1 and left `tokio = "1.43.0"` in three manifests. When the requirement is a plain version, Renovate matches an alert against it rather than the lockfile (CurrentVersionMatcher in its lib/util/package-rules/current-version.ts). The alert still matched, and #256 followed with 1.43.2. Each later tokio release would have opened another. Bump the requirement on security fixes instead. The manifest then leaves the vulnerable range and the alert stops matching after one PR. Other updates keep the lockfile-only strategy and the monthly group. This raises the tokio requirement of the published phper-test crate to the fixed version. Assisted-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.43.0→1.43.1Tokio broadcast channel calls clone in parallel, but does not require
SyncGHSA-rr8g-9fpq-6wmg
More information
Details
The broadcast channel internally calls
cloneon the stored value when receiving it, and only requiresT:Send. This means that using the broadcast channel with values that areSendbut notSynccan trigger unsoundness if thecloneimplementation makes use of the value being!Sync.Thank you to Austin Bonander for finding and reporting this issue.
Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:L/VA:N/SC:N/SI:N/SA:N/E:UReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
tokio-rs/tokio (tokio)
v1.43.1Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.