fix(pull-request): prioritize failed checks

[akash3444]

What Changed

PR checks now show failed and cancelled checks first.

Checks within the failing group and the remaining group keep the order reported by the provider. Duplicate check runs are still collapsed to the newest run.

Why

The overall CI indicator can report a failure while the failed check appears at the bottom of a long list. Users then have to scan or scroll through every check to find the cause.

Prioritizing failed checks makes the result behind the red status icon immediately visible without otherwise reshuffling the provider's ordering.

UI Changes

The checks popover and PR summary now place failed and cancelled checks at the top of the list.

Before:

After:

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes, not applicable

Built with GPT-5.6 Sol via the Codex harness in T3 Code.

Summary by CodeRabbit

• Enhancements
  • Pull request checks now show failed and cancelled checks first, making issues easier to identify while preserving the existing order and naming behavior for all other checks.
• Tests
  • Added coverage for prioritizing failed and cancelled checks, preserving order within status groups, handling similarly named checks, and validating expected ordering across supported providers.

[macroscopeapp]

Approvability

Verdict: Approved at 03abb02

Macroscope's review found this PR approvable — This is a small, focused fix that reorders existing pull-request checks so failed and cancelled results appear first, without changing check data or workflow behavior. The shared helper and provider expectations are covered by focused tests, and no sensitive, configuration, schema, or deployment files are involved.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 27d862ea-a5be-4673-94f3-8784bd36249d

📥 Commits

Reviewing files that changed from the base of the PR and between 03abb02 and bbaa378.

📒 Files selected for processing (1)

• apps/server/src/pullRequest/pullRequestChecks.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The pull request changes dedupeChecks to place failed and cancelled checks first. It preserves order within status groups and updates related test expectations.

Changes

Check ordering

Layer / File(s)	Summary
Prioritize failed and cancelled checks apps/server/src/pullRequest/pullRequestChecks.ts	dedupeChecks now returns failed or cancelled checks before other checks. The function documentation describes the ordering.
Validate ordered check results apps/server/src/pullRequest/*PullRequestJson.test.ts, apps/server/src/pullRequest/pullRequestChecks.test.ts	Tests cover status priority, preserved order within groups, and updated collision and provider expectations.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 24912

The ordering update is covered by focused tests and presents no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: failed checks are prioritized.
Description check	✅ Passed	The description explains what changed, why it changed, and includes before-and-after UI screenshots. The checklist is mostly complete, but the screenshot item remains unchecked despite the included sc…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[juliusmarminge]

Note

This comment is posted by Julius' dot

The screenshots show the visibility problem: failed checks sit among many successful checks. The patch replaces dedupeChecks’ documented provider-order behavior with failed/cancelled-first ordering for every consumer, and updates the provider expectations accordingly.

Can a maintainer confirm that status priority should replace provider order, including cancelled checks? No direction is linked or recorded here. The prior-approval rule asks for agreement on intentional behavior changes. Leaving this open for that focused ordering decision; the supplied screenshots and stable-within-group regression coverage are useful.

[maria-rcks]

Note

Written by claude-opus-5-5 on behalf of Maria

Hi! We are cleaning up open PRs, and this one appears to have been created with an older model (gpt-5.6-sol). If this change is really important, we recommend rebuilding the PR with a newer model if possible.

[maria-rcks]

Note

Written by claude-opus-5-5 on behalf of Maria

Reopening, this was closed by mistake. Sorry for the noise!