Repository navigation
Cull splats faded out by modifySplatColor before the GPU sort - #9962
Merged
Merged
Conversation
Build size reportThis PR changes the size of the minified bundles.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the WebGPU GPU-sort renderer, splats hidden by a
modifySplatColormodifier (alpha set to 0) were still compacted, cached and sorted, because the projector only culled on the original opacity.Changes:
modifySplatColor:valid = alpha > alphaClip. Faded-out splats no longer get a compaction slot, a projection cache entry or a sort key.alphaClipuniform, applied to the alpha that is drawn (AA-compensated in forward, uncompensated in pick).Performance:
modifySplatColor(fades, reveals, dissolves) no longer pay sort and vertex cost for the hidden splats.Fixes #9961