Repository navigation
Dispose the 3D Tiles renderers when the tiles examples are destroyed - #9985
Merged
Merged
Conversation
…oyed Switching away from the Mars or Helsinki 3D Tiles example while tiles were loading logged a "Failed to load tile" error and a TypeError for every tile still in flight, as their downloads completed after the application was destroyed. Both examples now dispose their TilesRenderer on the application's destroy event, which aborts the pending loads.
Build size reportThis PR does not change the size of the minified bundles.
|
mvaligursky
added a commit
that referenced
this pull request
Nov 9, 2026
…oyed (#9985) Switching away from the Mars or Helsinki 3D Tiles example while tiles were loading logged a "Failed to load tile" error and a TypeError for every tile still in flight, as their downloads completed after the application was destroyed. Both examples now dispose their TilesRenderer on the application's destroy event, which aborts the pending loads. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to another example while the Mars or Helsinki 3D Tiles example was still loading logged a
TilesRenderer : Failed to load tileerror and aTypeError: Cannot read properties of null (reading 'add')for every tile in flight. Their downloads completed after the application was destroyed and were parsed against the released asset registry.Changes:
TilesRendereron the application'sdestroyevent, which aborts the pending downloads and parses.Examples:
integrations/mars-3d-tilesintegrations/helsinki-3d-tiles