Repository navigation
parity_compile --cli: batch the CLI compiles - #103
Merged
Merged
Conversation
…one cleanmodels call instead of one process per file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parity_compile.py --clistartedcleanmodels compileonce per model, which was about two thirds of a full corpus run. It now compiles each directory's files in batches of 2000 with one call (--workers= CPU count) into an output directory and compares the outputs' hashes; a file the CLI refuses has no output, as before.Measured on 4,104 game models (every 8th): 178 s → 81 s for the compile step, the CLI part 105 s → 10 s. Results unchanged (all identical).
Checked that it still catches a difference: with a fake CLI that corrupts one output per call, exactly those files are reported as
bytes differ from the CLI's.Only the test script changes; nothing it tests.