Repository navigation
[Fix]: unclear and false positive warnings + an issue with additional informations targetting same field name over differents items (Glpi 12) - #701
Merged
Conversation
3 of 4 tasks
RomainLvr
approved these changes
Nov 9, 2026
Lainow
approved these changes
Nov 9, 2026
jdurand-teclib
added a commit
that referenced
this pull request
Nov 10, 2026
… informations targetting same field name over differents items (Glpi 11) (#695) > [!NOTE] > This PR also exists for Glpi 12. #701 - [x] I have performed a self-review of my code. - [x] I have added tests (when available) that prove my fix is effective or that my feature works. - [x] I have updated the CHANGELOG with a short functional description of the fix or new feature. - [ ] This change requires a documentation update. ## Description - It fixes !47354 - Here is a brief description of what this PR does - Change unclear and generic warning messages in the logs into more explicit ones (especially for mapping issues) - Added a warning message when attempting to connect an item to a network port results in finding 0 or several ports - Fix a false positive warning when creating a network port without requesting it to be attached to a switch (considered as failed and triggered a warning) - Fix 2 issues regarding additional informations sharing a field name accross multiple itemtypes - they were overwritting eachother (i.e a Memory name overwritting a Processor name, or both having the same name...) - The data data injection form was only displaying the names of the fields, and not their itemtype (c.f screenshots) Unit tests to cover changes and ensure no regression ## Screenshots (if appropriate): Before solving the field names display issue: <img width="1835" height="872" alt="image" src="https://github.com/user-attachments/assets/698feabc-6c52-41d7-a813-01b1bd9587b5" /> After: <img width="1835" height="872" alt="image" src="https://github.com/user-attachments/assets/f44ca16e-e9f7-4b6b-b34f-e60283e9f9b8" /> --------- Co-authored-by: Julien Durand <300495670+jdurand-teclib@users.noreply.github.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is the Glpi 12 version of #695
Description
Unit tests to cover changes and ensure no regression
Screenshots (if appropriate):
Before solving the field names display issue:

After:
