Repository navigation
Conversation
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python builds currently force
-vvfor both uv and pip, so a normalpixi installprints debug and trace output. Derive installer verbosity from the backend's build logging level instead, using the same behavior for both installers.Forward Pixi's CLI verbosity through immutable per-dispatcher configuration to spawned JSON-RPC backends, including
pixi-build-rattler-build. Normal invocations retain the backend's default logging;-vvenables backend debug logging,-vvvand above enable trace logging, and-qdisables build logging. This does not rewrite commands in user-provided recipe scripts.Adapted from @Jamison929611's #6806, including its updated installer-generic approach requested in review. Strengthens the regression coverage by exercising the actual tracing filter and checking both pip and uv script generation on Unix and Windows, including preservation of extra arguments and editable installs.
Fixes #6099
How Has This Been Tested?
cargo test --locked -p pixi_build_frontend -p pixi-build-python: 7 frontend tests and 93 Python backend tests passed; 1 ignored.cargo test --offline -p pixi-build-python: 93 passed, 1 ignored, after strengthening the logging-filter regression test.cargo test --locked -p pixi_command_dispatcher: 176 unit tests and 43 integration tests passed; 2 integration tests and 2 doc tests ignored.cargo check --locked -p pixi_clicargo clippy --locked -p pixi_build_frontend -p pixi-build-python -p pixi_command_dispatcher -p pixi_cli --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkWindows script generation was tested locally; native Windows execution was not tested.
AI Disclosure
Tools: Codex
Prompt: Fix #6099 after reviewing #6806 and avoiding the installer-specific verbosity issue identified in review; verify how forwarding interacts with pixi-build-rattler-build and create a draft PR.
Checklist: