Repository navigation
Conversation
Jarod42
reviewed
Nov 13, 2026
| prepare() | ||
| local node = p.project.getsourcetree(cfg.project).children["main.cpp"] | ||
| local filecfg = p.fileconfig.getconfig(node, cfg) | ||
| test.isequal({ "-U_MSVC_STL_DESTRUCTOR_TOMBSTONES", "-D_MSVC_STL_DESTRUCTOR_TOMBSTONES=0" }, clang.getcxxflags(filecfg)) |
Contributor
There was a problem hiding this comment.
That Undefine seems unneeded when global is default.
not tested interesting cases seems to be:
- global On, main.cpp Off
- global On, main.cpp Default (That one seems wrong BTW)
And expected would be either -DXxx=1 -UXxx -DXxx=0 or simply -DXxx=0
(Even if tests show actual (valid) value instead of possible valid values)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the MS STL destructor tombstones setting from #2569.
How does this PR change Premake's behavior?
Adds stltombstones with Default, On, and Off modes. It only applies to C++. Clang also gets it on Windows when no stl value is set.
For Visual Studio the macro goes on each C++ file when a project mixes C and C++ as MSBuild does not let me condition ItemDefinitionGroup on the file extension. I also kept the macro in a small table (m.cxxDefines) so that hardenstl can reuse it later.
Anything else we should know?
Source tests and docs-check pass. I also tested with VS2026, VS2022, GNU Make, and Ninja using both MSVC and Clang.
A C++ file in a linked SharedItems project does not get the macro when the consumer writes it per file unless that project sets stltombstones itself.
A few best guesses:
Did you check all the boxes?