Skip to content

Add the stltombstones setting - #2827

Open
Rinzii wants to merge 1 commit into
premake:masterfrom
Rinzii:ian/stltombstones
Open

Rinzii wants to merge 1 commit into
premake:masterfrom
Rinzii:ian/stltombstones

Conversation

@Rinzii

@Rinzii Rinzii commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds the MS STL destructor tombstones setting from #2569.

How does this PR change Premake's behavior?

Adds stltombstones with Default, On, and Off modes. It only applies to C++. Clang also gets it on Windows when no stl value is set.

For Visual Studio the macro goes on each C++ file when a project mixes C and C++ as MSBuild does not let me condition ItemDefinitionGroup on the file extension. I also kept the macro in a small table (m.cxxDefines) so that hardenstl can reuse it later.

Anything else we should know?

Source tests and docs-check pass. I also tested with VS2026, VS2022, GNU Make, and Ninja using both MSVC and Clang.

A C++ file in a linked SharedItems project does not get the macro when the consumer writes it per file unless that project sets stltombstones itself.

A few best guesses:

  • The 17.14 requirement comes from the MS STL changelog.
  • VS2005 and VS2008 also pass the macro to C files. I haven't built with either as they are quite old.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

prepare()
local node = p.project.getsourcetree(cfg.project).children["main.cpp"]
local filecfg = p.fileconfig.getconfig(node, cfg)
test.isequal({ "-U_MSVC_STL_DESTRUCTOR_TOMBSTONES", "-D_MSVC_STL_DESTRUCTOR_TOMBSTONES=0" }, clang.getcxxflags(filecfg))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That Undefine seems unneeded when global is default.

not tested interesting cases seems to be:

  • global On, main.cpp Off
  • global On, main.cpp Default (That one seems wrong BTW)

And expected would be either -DXxx=1 -UXxx -DXxx=0 or simply -DXxx=0
(Even if tests show actual (valid) value instead of possible valid values)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants