Skip to content

fix(storage)!: expire email validation codes - #2045

Merged
nijel merged 1 commit into
masterfrom
expiry
Oct 2, 2026
Merged

nijel merged 1 commit into
masterfrom
expiry

Conversation

@nijel

@nijel nijel commented Oct 2, 2026

Copy link
Copy Markdown
Member

Reject expired codes during validation so their lifetime does not depend on scheduled cleanup. Default to seven days and preserve single-use validation.

BREAKING CHANGE: Code storage must persist creation timestamps; undated codes are rejected when expiry is enabled.

Fixes #202
Fixes #203

Reject expired codes during validation so their lifetime does not depend on
scheduled cleanup. Default to seven days and preserve single-use validation.

BREAKING CHANGE: Code storage must persist creation timestamps; undated codes
are rejected when expiry is enabled.

Fixes #202
Fixes #203
@nijel nijel self-assigned this Oct 2, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T06:43:00.499753Z 51deb5b PR opened
🔒 Security Review ✅ Completed 2026-10-02T06:43:45.968499Z 51deb5b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.07%. Comparing base (b09b54b) to head (51deb5b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
+ Coverage   91.90%   92.07%   +0.17%     
==========================================
  Files         357      357              
  Lines       16354    16431      +77     
  Branches      832      839       +7     
==========================================
+ Hits        15030    15129      +99     
+ Misses       1082     1060      -22     
  Partials      242      242              
Flag Coverage Δ
unittests 92.07% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nijel
nijel merged commit 41bacc2 into master Oct 2, 2026
37 checks passed
@nijel
nijel deleted the expiry branch October 2, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add settings for mail_validation to allow for reusable and time-expiring codes

1 participant