Repository navigation
Conversation
|
Hi @soma0212! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
any update? |
|
Independent reproduction on an NVIDIA GB10 (aarch64, Cortex-A725), which may help get this merged: Topology: 20 CPUs online ( Symptom:
With the counting pass made sysfs-aware (and the L2 writes bounds-checked like L3), valgrind reports 0 errors and the reported topology matches sysfs. Patch: ModelCloud@4c0907a |
|
Adding the exact environment for the reproduction above, because the trigger is a
The kernel's own view of the CPU set is inconsistent: cpuinfo enumerates 19 processors from the sysfs set (cpu1..cpu19) but finds no The kernel-side inconsistency is what reaches the state; the unguarded |
|
Opened #457 which carries this counting-pass fix (your commit is cherry-picked with authorship preserved) plus two additions:
Confirmed on real hardware too: NVIDIA GB10 (aarch64, Ubuntu 26.04, kernel 7.3.1-gb10), CPU 19 is online in sysfs but absent from Note that current |
The L2 cache count and population passes in cpuinfo_arm_linux_init disagree on when a core gets an L2 entry:
Applying the same sysfs size override in the counting pass keeps l2_count aligned with the number of entries written.