Repository navigation
Qualcomm AI Engine Direct - Separate model class into model_family + model_id - #24762
Open
qti-mmadhava wants to merge 3 commits into
Open
qti-mmadhava wants to merge 3 commits into
qti-mmadhava wants to merge 3 commits into
Conversation
qti-mmadhava
requested review from
larryliu0820 and
mergennachin
as code owners
November 7, 2026 01:28
This PR needs a
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.model_classselector into:base.model_familyfor architecture and export-pathselection.
base.model_idfor specific model selection, checkpoint download and artifactnaming.
model_familyandmodel_idare mutually exclusive.base.paramsrequired for everymodel_id, including legacymodel_classthat resolves to an id.model_classwith either new field.model loading, and documentation to use the new identity fields.
routing, checkpoint download selection, checkpoint override
behavior, and legacy OmegaConf input.
model_id, ormodel_familywhen nomodel_idis selected. Legacymodel_class=static_llamanow defaults to llama3_2.pte instead of static_llama.pte.This is a follow up for RFC #20402
Test plan
python -m unittest \ executorch.examples.models.llama.config.test_llm_config \ executorch.examples.models.llama.tests.test_export_llama_libpython -m extension.llm.export.export_llm \ base.model_id=qwen3_0_6b \ base.params=examples/models/qwen3/config/0_6b_config.json \ model.use_kv_cache=false \ export.max_seq_length=4 \ export.max_context_length=4 \ export.output_dir=/tmp \ export.output_name=qwen3_model_idcc @psiddh @JacobSzwejbka @digantdesai