Repository navigation
Fix hub-sliding-sessions-e2e login route (bd-gppva1ee) - #844
Merged
Merged
Conversation
…pva1ee) The script still posted to /auth/refresh, renamed to /auth/session in bd-s042qcxj (PR #417), so it failed at step 1 with a 404. Payload and CSRF contract unchanged ({ credential } JSON + X-Requested-With); the script's mock IdP is a Generic provider, for which /auth/session is the registered mint endpoint. Verified end-to-end: pre-fix run failed at step 1 (status=404); post-fix run against the real hub binary passes all 16 checks, including the 120 s sliding-session outliving leg.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The script
scripts/hub-sliding-sessions-e2e.mjsfailed at step 1. It logged in withPOST /auth/refresh. That route was renamed to/auth/sessionin bd-s042qcxj (PR #417), so the hub returned 404 and the script crashed.The change
Renames the three mentions of
/auth/refreshto/auth/session: one comment, onefetch, one check label. Nothing else changes. The request body ({ credential }) and the CSRF header already match what/auth/sessionexpects. The script's mock IdP is a Generic OIDC provider, so/auth/sessionis the right login endpoint.Verification
Ran the script against the real
hubbinary, before and after:Closes bd-gppva1ee.