Skip to content

Fix quarto_preview_stop process tracking - #305

Merged
cderv merged 7 commits into
quarto-dev:mainfrom
cderv:test/quarto-preview-stop-regression
Sep 10, 2026
Merged

cderv merged 7 commits into
quarto-dev:mainfrom
cderv:test/quarto-preview-stop-regression

Conversation

@cderv

@cderv cderv commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

  • store preview daemon state in a shared environment so process updates persist across calls
  • add a subprocess regression test verifying that stopping a preview releases its port
  • support both source-tree development tests and installed-package checks

Closes #304

Testing

  • devtools::test(filter = "preview") — 1 passed, 2 pre-existing interactive skips
  • devtools::check(document = FALSE, manual = FALSE, args = "--no-vignettes", build_args = "--no-build-vignettes") — 0 errors; vignette warnings expected because vignette building was disabled

@cderv
cderv force-pushed the test/quarto-preview-stop-regression branch from 9cc2295 to 3fbd2bb Compare September 10, 2026 10:57
@cderv
cderv merged commit e2a8c69 into quarto-dev:main Sep 10, 2026
18 checks passed
@cderv
cderv deleted the test/quarto-preview-stop-regression branch September 10, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quarto_preview_stop fails to stop preview server

1 participant