Repository navigation
feat(auth): opt-in unattended sign-in with a stored authenticator #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
55e806b
feat(auth): opt-in unattended sign-in with a stored authenticator
rabesss 253a88e
test: mark the second TOTP fixture key for gitleaks
rabesss b61af23
fix(relogin): fail closed on breaker state and recover from a fast clock
rabesss 0962d8b
docs(cli): say in auth login --help that a stored authenticator skips…
rabesss 783702e
ci: ignore the fake TOTP fixture key in the PR's first commit
rabesss 34bf5ca
fix(relogin): never resend a used time step, and block while signing in
rabesss 56673b2
docs: say that only write requests skip sign-in, and qualify the logi…
rabesss ba2abbd
fix(relogin): never let totp-setup forget used time steps
rabesss 6256fe0
fix(auth): point a failed stored login at the login that clears the b…
rabesss e097ba1
fix(relogin): keep ordinary commands working without fcntl
rabesss 4db986f
fix(display): keep the sign-in category when an error is formatted twice
rabesss 0ee2e16
fix(api): only the process that signs in says it is signing in
rabesss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 55e806ba7338095a15f052f6a78a6700404d368b:tests/test_auth_totp.py:generic-api-key:32 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SUGGESTION]:
categoryis documented as conditional but is always presentThe implementation always includes
categoryin failure documents, withnullwhen no automatic sign-in was attempted (_status_payload; tests assert"category": None). A consumer written strictly from this wording could mishandle the always-presentnull. Suggested wording: "and acategory(null when no automatic sign-in was attempted)".Reply with
@kilocode-bot fix itto have Kilo Code address this issue.