Forward-merge release/26.10 into main - #1237
Merged
Merged
Conversation
Breathe 5.0.0 breaks the docs build on every constexpr constructor. It renders `constexpr` from the member's attribute and is meant to strip it from the type, but Doxygen 1.18 gives a constructor a type of just `constexpr`, which the stripping misses. The qualifier then appears twice, Sphinx's C++ parser rejects the declaration, and since warnings are errors the build fails. `clean_doxygen_xml` now clears a type that is only `constexpr` when the member also has the attribute. It does so only for Breathe 5 and later, because older Breathe reads `constexpr` from the type alone and would lose it. Verified by rendering `docs/source/cpp/*.md` against Doxygen 1.18.0 XML with Sphinx 8.2.3. With Breathe 5.0.0 the five parse errors are gone, with Breathe 4.36.0 and 4.35.0 the output is unchanged, and all three render each constexpr constructor with a single `constexpr`. cudf might need something similar. Its Doxygen 1.18 XML has the same pattern, and AFAICT `clean_definitions` in `docs/cudf/source/conf.py` doesn't handle it. Authors: - Mads R. B. Kristensen (https://github.com/madsbk) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #1231 (cherry picked from commit 10282c8) Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.10 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.