Repository navigation
fix(openssl): sign RSA-PSS with a salt as long as the digest - #307
Merged
Merged
Conversation
The PSS salt length was left to the linked OpenSSL. 3.0 signs with the longest salt the key allows and later versions with the digest length, so the same step wrote different signatures depending on the build, and a verifier that expects the usual 32 bytes refused the 3.0 ones. Signing now sets the length to the digest's. Verification still reads it from the signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSS salt length was left to the linked OpenSSL: 3.0 signs with the longest salt the key allows, later versions with the digest length. Signing now sets it to the digest length, 32 bytes for SHA-256. Verification still reads the length from the signature, so signatures with other salt lengths keep verifying.