Repository navigation
fix(rivetkit): send request bodies as bytes for browser clients - #5802
Merged
eersnington merged 1 commit intoOct 2, 2026
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
Contributor
ReviewThe fix is small and targeted. Buffering the body as bytes is the right approach for browsers. I found no blocking issues. Observations
Overall this looks good to merge, with a regression test as a nice-to-have. |
eersnington
force-pushed
the
stack/fix-rivetkit-send-request-bodies-as-bytes-for-browser-clients-krwoyzyq
branch
from
September 28, 2026 15:01
2ac03e0 to
275067c
Compare
eersnington
force-pushed
the
stack/fix-rivetkit-send-request-bodies-as-bytes-for-browser-clients-krwoyzyq
branch
from
October 1, 2026 22:20
275067c to
e401599
Compare
NathanFlurry
approved these changes
Oct 1, 2026
eersnington
force-pushed
the
stack/fix-rivetkit-send-request-bodies-as-bytes-for-browser-clients-krwoyzyq
branch
from
October 2, 2026 00:17
9a8e780 to
6161d86
Compare
eersnington
deleted the
stack/fix-rivetkit-send-request-bodies-as-bytes-for-browser-clients-krwoyzyq
branch
October 2, 2026 00:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadableStreamwithduplex: "half". Since feat(http): stream HTTP bodies end-to-end #5516, action calls on a handle without.connect()failed in Safari, Firefox, and Chromium over HTTP/1.1.Requestpassed tohandle.fetch()as bytes. Firefox has noRequest.body, so the body was dropped.Failed to fetch