Skip to content

refactor: simplification - #112

Open
rustatian wants to merge 1 commit into
masterfrom
refactor/simplification
Open

rustatian wants to merge 1 commit into
masterfrom
refactor/simplification

Conversation

@rustatian

Copy link
Copy Markdown
Member

Reason for This PR

Remove duplicate work from configuration flag parsing.

Description of Changes

  • Split flags once with strings.Cut and remove an unreachable error branch.
  • Build escaped quote strings without formatted output.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 4, 2026 17:31
@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.35%. Comparing base (f0bb3ae) to head (f380c95).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   98.71%   99.35%   +0.63%     
==========================================
  Files           3        3              
  Lines         156      154       -2     
==========================================
- Hits          154      153       -1     
+ Misses          2        1       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The refactor preserves existing behavior and remains covered by current parsing tests.

Review effort: Balanced
Findings: None

What changed in this PR

Simplifies configuration flag parsing without changing behavior.

Changes:

  • Uses strings.Cut to parse flags once.
  • Replaces formatted quote escaping with string concatenation.
File Description
plugin.go Simplifies flag splitting and escaped-quote construction.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants