Repository navigation
Conversation
pcanal
requested review from
bellenot,
dpiparo,
jblomer and
linev
as code owners
April 8, 2026 20:11
pcanal
marked this pull request as draft
April 8, 2026 20:11
Test Results 20 files 20 suites 2d 22h 34m 24s ⏱️ Results for commit d344fa1. ♻️ This comment has been updated with latest results. |
pcanal
force-pushed
the
very_large_collection
branch
from
April 10, 2026 21:29
2919c36 to
c364f50
Compare
pcanal
force-pushed
the
very_large_collection
branch
6 times, most recently
from
April 23, 2026 22:09
6891a9f to
f3f405d
Compare
pcanal
force-pushed
the
very_large_collection
branch
4 times, most recently
from
May 5, 2026 15:33
c8692de to
59db0dc
Compare
pcanal
force-pushed
the
very_large_collection
branch
2 times, most recently
from
June 19, 2026 22:24
b5f2099 to
2e2c703
Compare
pcanal
force-pushed
the
very_large_collection
branch
from
June 20, 2026 17:21
2e2c703 to
408b5f4
Compare
It is staying signed for historical reason since we do not plan to support collection larger than std::numeric_limit<std::int64_t>::max() as onfile we reserve the sign bit as a marker.
note: std::signbit(int) not avail on Windows
NOTE: this might be backward incompatible
The change in TStreamerInfo class version changes the compressed size of the TStreamerInfo record in the file. In this test, the file is updated/added-to, consequently the keys/baskets that are written after the first TStreamerInfo record are moved slightly and this changes the compressed size of the TTree object on file.
This is use in particular for TClass to register the upcoming object type.
pcanal
force-pushed
the
very_large_collection
branch
from
November 11, 2026 16:41
c248d7b to
d344fa1
Compare
pcanal
marked this pull request as ready for review
November 11, 2026 16:41
jblomer
approved these changes
Nov 11, 2026
| // we fail. | ||
| { | ||
| TClass__GetCallingNewRAII callingNew(defConstructor); | ||
| p = gCling->ClassInfo_New(GetClassInfo(),nElements, arena); |
Contributor
There was a problem hiding this comment.
I think we need to update this, too, since it takes an int parameter
| char *Buffer() const { return fBuffer; } | ||
| char *GetCurrent() const { return fBufCur; } | ||
| Int_t BufferSize() const { return fBufSize; } | ||
| Size_t BufferSize() const { return fBufSize; } |
Contributor
There was a problem hiding this comment.
Requires updating TMapRec (see MapFile::Update()).
| Size_t BufferSize() const { return fBufSize; } | ||
| void DetachBuffer() { fBuffer = nullptr; } | ||
| Int_t Length() const { return (Int_t)(fBufCur - fBuffer); } | ||
| Size_t Length() const { return (Size_t)(fBufCur - fBuffer); } |
Contributor
There was a problem hiding this comment.
- Requires updating
TDNDData(plus a follow-up fix inTGDNDManager::HandleSelectionRequest()). Int_t posinTClass::Load().- MPSendRecv passes a buffer length to
TSocket::SendRaw(). TContainerConvertershas a lineInt_t currentpos = b.Length().- In
TStreamerInfo::ReadBufferthere is a lineInt_t bufpos = b.Length(). - Fix the return statement in
RNTupleSerializer::SerializeStreamerInfos. - Fix
bufOffsetinTTreeReaderValueFastBase::Adjust(). - Maybe also add an overflow- checked
LengthAsInt()for its use in TKey.
| kCustomAlloc = BIT(5) ///< The collection has a custom allocator. | ||
| }; | ||
|
|
||
| using size_type = UInt_t; |
Contributor
There was a problem hiding this comment.
SizeType_t? (Not sure what the consistent spelling is in this context).
| int res = unittestByteCount(); | ||
| res += testReadWriteObjectAny(); | ||
| return res; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Missing newline at the end of the file.
| return ru.ru_maxrss / 1024.0; | ||
| #endif | ||
| } | ||
| #define TIME_SUBTEST(timing, label, call) \ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review -- just running the CI for a checkpoint.