Repository navigation
[RF] Remove the legacy evaluation backend - #23265
Merged
guitargeek merged 2 commits intoNov 12, 2026
Merged
Conversation
Test Results 20 files 20 suites 3d 3h 22m 50s ⏱️ For more details on these failures, see this check. Results for commit 72d5587. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
3 times, most recently
from
September 10, 2026 16:49
7820e08 to
0075fa0
Compare
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
September 14, 2026 19:28
0075fa0 to
5dd456a
Compare
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
October 19, 2026 07:30
5dd456a to
554e8c1
Compare
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
October 29, 2026 23:21
554e8c1 to
d20e739
Compare
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
3 times, most recently
from
November 9, 2026 13:02
7aeb573 to
fab4e8e
Compare
guitargeek
marked this pull request as ready for review
November 9, 2026 15:08
guitargeek
requested review from
bellenot,
dpiparo and
hageboeck
as code owners
November 9, 2026 15:08
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
2 times, most recently
from
November 9, 2026 21:51
f15d7bf to
aa721a1
Compare
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
November 10, 2026 14:34
aa721a1 to
912285b
Compare
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
November 10, 2026 16:10
912285b to
30b9fca
Compare
dpiparo
approved these changes
Nov 11, 2026
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
November 11, 2026 07:59
30b9fca to
585b553
Compare
Contributor
Author
|
Thanks for the review! Final push to resolve merge merge conflicts in header includes. |
Keep the coverage of the remaining code when the legacy backend goes:
* Tests that used the legacy backend as the reference compare with
the "cpu" backend now: the chi2 backend cross-checks, the HS3 test
suite, the TestStatistics likelihood tests, RooNLLVar.CopyRangedNLL,
RooRealL.setVal and the binned LikelihoodSerial test. Tests that
were only enabled with the legacy backend run unconditionally.
* Vectorized pdf fixtures with a disabled fit test ran their "cpu" fit
only in the comparison with the legacy fit. Their fit tests are
enabled now, except for the two "Gauss + Gauss + Exp" fixtures that
miss the 1 % yield tolerance; a new test checks their convergence.
* The HistFactory evaluation test checked the scalar getVal() only
with the legacy backend. Now it compares it to the vectorized
evaluation.
* LikelihoodGradientJobTest.GaussianND never ran because of a
misspelled guard macro. It runs now, with relative tolerances.
Assisted-by: claude-code:claude-opus-5-5
The legacy backend for likelihood and chi-square fits was superseded by
the vectorized "cpu" backend, the default since ROOT 6.32, and had no
performance-relevant feature left since the removal of the constant
term optimization.
* RooFit::EvalBackend::Legacy() and its enum value are removed;
EvalBackend("legacy") throws, saying that the backend was removed.
The BatchMode() definitions, undeclared since 42e4cdc, go too.
* The legacy test statistics RooNLLVar, RooChi2Var,
RooAbsOptTestStatistic and RooAbsTestStatistic are removed, and so
is their multiprocessing with RooRealMPFE and BidirMMapPipe.
NumCPU() no longer forks processes: it only sets the number of
threads for the batch evaluation in RooBatchCompute and ignores its
interleaving strategy. The multi-process alternative remains
RooFit::Parallelize(), based on RooFit::MultiProcess.
* The factory expressions nll::name[pdf,data] and chi2::name[pdf,data]
are removed with the classes they instantiated.
* RooFormulaVar::defaultErrorLevel() recognizes the test statistics of
the new backends, like RooAddition. It only recognized the legacy
classes before, so a RooFormulaVar wrapping a "cpu" likelihood had
the error level 1 instead of 0.5.
* RooFit::TestStatistics::RooUnbinnedL always uses the
RooFit::Evaluator now, and RooUnbinnedL and the NLLFactory default
to the "cpu" backend instead of "legacy". RooAbsL::GetInfo() reports
the name of the pdf compiled for the normalization set.
* The roofit_legacy_eval_backend CMake option is gone, and xroofit is
built unconditionally on non-MSVC platforms.
Legacy-only tests and the legacy instances of tests that run with every
backend are removed; the previous commit made the other tests
independent of the legacy backend. New tests cover the error level of
wrapped test statistics and the error for the removed backend.
Assisted-by: claude-code:claude-opus-5-5
guitargeek
force-pushed
the
remove-legacy-eval-backend
branch
from
November 11, 2026 11:15
585b553 to
72d5587
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy evaluation backend was deprecated in ROOT 6.42 and is now removed, as announced in the 6.42 release notes. It was superseded by the vectorized "cpu" backend, the default since ROOT 6.32, and has had no performance relevant feature left since the constant term optimization was removed.
Removed
RooFit::EvalBackend::Legacy().EvalBackend("legacy")now throws. The leftoverBatchMode()definitions are removed too.RooNLLVar,RooChi2Var,RooAbsOptTestStatisticandRooAbsTestStatistic, and their multiprocessing viaRooRealMPFEandBidirMMapPipe(~7k lines).nll::name[pdf,data]andchi2::name[pdf,data]factory expressions.Behaviour changes
NumCPU()no longer forks processes. It only sets the number of threads for RooBatchCompute and ignores the interleaving strategy. For multi-process fits, useRooFit::Parallelize().RooFormulaVar::defaultErrorLevel()now recognizes the test statistics of the new backends. ARooFormulaVarthat wraps a "cpu" likelihood now gets error level 0.5 instead of 1.RooFit::TestStatistics::RooUnbinnedLand theNLLFactorynow default to the "cpu" backend.Preparatory fixes
LikelihoodGradientJobTest.GaussianND, which had a misspelled guard macro.The 6.44 release notes are updated accordingly.