Repository navigation
Conversation
Test Results 22 files 22 suites 3d 17h 21m 38s ⏱️ For more details on these failures, see this check. Results for commit 2d20c8e. ♻️ This comment has been updated with latest results. |
jblomer
reviewed
Sep 23, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! In principle LGTM. But see the clang format report.
ffurano
force-pushed
the
fab_netx
branch
3 times, most recently
from
October 2, 2026 13:06
a123162 to
b4f564c
Compare
jblomer
approved these changes
Oct 13, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! LGTM. Some tiny comments, and please check the CI errors.
Contributor
|
@ffurano If possible, please make the necessary final edits to this PR until Thursday next week. This way we can make sure that this change make it in the v6.42 release. |
Replace the repeated per-parameter blocks with loops over tables for the XrdCl NetXNG.* parameters, the XSec.* -> XrdSec* environment variables and the NetXNG.S3.* parameters. Also fix NetXNG.ConnectionRetry, which was setting the XrdCl RequestTimeout parameter instead of ConnectionRetry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dpiparo
marked this pull request as draft
November 4, 2026 13:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request puts some order and documentation for
the TEnv parameters that are needed by TNetXNGFile to
deal with http and s3 servers.
Some parameters have been introduced in order to be compatible (or
more similar) to the TDavixFile configuration.