Repository navigation
Conversation
git clone from repository is very "expensive" in terms of time and traffic produced. In fact only very small core part of the civetweb code is used in the ROOT. Therefore just create minimal tarball ourself and download it
Test Results 21 files 21 suites 3d 13h 19m 21s ⏱️ Results for commit 015a3bb. ♻️ This comment has been updated with latest results. |
linev
changed the title
588860e3 commit
| # URL_HASH SHA256=${ROOT_CIVETWEB_HASH} | ||
|
|
||
| # ------- here is extract of 588860e3 commit ------ | ||
| URL https://jsroot.gsi.de/civetweb-588860e3.tar.gz |
There was a problem hiding this comment.
| URL https://jsroot.gsi.de/civetweb-588860e3.tar.gz | |
| URL https://root.cern/download/civetweb-588860e3.tar.gz | |
| https://jsroot.gsi.de/civetweb-588860e3.tar.gz |
With #23963, I'm trying to ensure that every tarball has two mirrors: one at CERN (usually LCG), tried first, and then an "external" (usually GitHub).
To preserve this also for civetweb, maybe we can put the same civetweb-588860e3.tar.gz also on root.cern? If the tarball is final, then @dpiparo could upload it there
There was a problem hiding this comment.
@guitargeek
Lets wait until all builds are green.
I also see some warnings during build (on my Linux I normally using external civetweb) and want to fix them
There was a problem hiding this comment.
I think having two sources is a great idea. Now some thoughts:
- We usually put source tarballs on the LCG site
- If we put the source on the LCG site and on ROOT's site, we do not make ourselves immune to potential service disruptions since the infrastructure behind the the two websites is the same
There was a problem hiding this comment.
* We usually put source tarballs on the LCG site
I think in this case we shouldn't do this: our LCG colleagues usually use released versions of software, not random commits
* If we put the source on the LCG site and on ROOT's site, we do not make ourselves immune to potential service disruptions since the infrastructure behind the the two websites is the same
That's why I think one source on ROOT and one on GSI is pretty good!
|
Need to restart for clean build |
d7d7d18 to
afff951
Compare
Put in civetweb-588860e3.tar.gz code from 588860e3 commit and apply our patches to it. Then build with same commands as with git checkout
afff951 to
015a3bb
Compare
|
Note that #23974 is now merged, so you could also add the |
git clone from repository is very "expensive" in terms of time and produced traffic.
In fact only very small core part of the civetweb code is used in the ROOT.
Therefore just create minimal tarball ourself, download it and apply same patches as for git repository
Trying also fix cmake warning when provide list of libs as argument - trying to use
LIST_SEPARATOR "|"argument