Repository navigation
[tmva] add headers to private file_sets - #23986
Merged
Merged
Conversation
ferdymercury
changed the title
ferdymercury
marked this pull request as ready for review
November 4, 2026 16:26
Collaborator
Author
|
If this and all preceding pull requests are merged, one can finally close https://its.cern.ch/jira/browse/ROOT-10915 |
Test Results 22 files 22 suites 3d 11h 10m 31s ⏱️ For more details on these failures, see this check. Results for commit 9f562da. ♻️ This comment has been updated with latest results. |
guitargeek
approved these changes
Nov 5, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks. No matter what we decide later for ROOT_STANDARD_LIBRARY_PACKAGE, we want these headers in the FILE_SETS anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see rationale in #20515 (comment)